Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.librosa: fix required package pooch #95605

Merged
merged 2 commits into from Aug 27, 2020
Merged

pythonPackages.librosa: fix required package pooch #95605

merged 2 commits into from Aug 27, 2020

Conversation

GuillaumeDesforges
Copy link
Contributor

@GuillaumeDesforges GuillaumeDesforges commented Aug 16, 2020 •
edited

Motivation for this change

Librosa 0.7.2 fails to load after update of numba to 0.50
librosa/librosa#1160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GuillaumeDesforges
Copy link
Contributor Author

Test:

$ nix-shell --expr "let pkgs = import ./default.nix {}; in pkgs.mkShell { buildInputs = [(pkgs.python3.withPackages (pp: [pp.librosa ]))]; }" --run "python -c 'import librosa; print(librosa.__version__)'"
0.8.0

while previously it throwed a:

ModuleNotFoundError: No module named 'numba.decorators'

@jonringer jonringer mentioned this pull request Aug 17, 2020
Merged
10 tasks
jonringer
jonringer reviewed Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a commit per package addition/update, should be:

python3Packages.pooch: init at 1.0.0
python3Packages.librosa: 0.7.2 -> 0.8.0

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches when creating commits.

pkgs/development/python-modules/pooch/default.nix Show resolved Hide resolved
@GuillaumeDesforges
Copy link
Contributor Author

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches when creating commits.

I understand your reply, however I have looked at the manual again and could not find anything about "1 commit per package" policy. It makes sense though, and I will make the required changes.

@jonringer
Copy link
Contributor

they only guidance is:

Make commits of logical units.

but each package in this case i would consider a logical unit

if you did a bump, then a major refactor, I would probably consider that two logical units for a single package.

@GuillaumeDesforges GuillaumeDesforges changed the title librosa: 0.7.2 -> 0.8.0 pythonPackages.librosa: fix required package pooch Aug 27, 2020
jonringer
jonringer approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95605 1

4 packages built:
- python37Packages.librosa
- python37Packages.pooch
- python38Packages.librosa
- python38Packages.pooch

@jonringer jonringer merged commit c631a19 into NixOS:master Aug 27, 2020
@GuillaumeDesforges GuillaumeDesforges deleted the pr/librosa-0.8.0 branch August 27, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GuillaumeDesforges @jonringer