New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.librosa: fix required package pooch #95605
Conversation
Test:
while previously it throwed a:
|
76c640c
to
f2395cd
Compare
f2395cd
to
f172782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a commit per package addition/update, should be:
python3Packages.pooch: init at 1.0.0
python3Packages.librosa: 0.7.2 -> 0.8.0
Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches when creating commits.
I understand your reply, however I have looked at the manual again and could not find anything about "1 commit per package" policy. It makes sense though, and I will make the required changes. |
they only guidance is:
but each package in this case i would consider a logical unit if you did a bump, then a major refactor, I would probably consider that two logical units for a single package. |
f172782
to
72483bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 95605 1
4 packages built:
- python37Packages.librosa
- python37Packages.pooch
- python38Packages.librosa
- python38Packages.pooch
Motivation for this change
Librosa 0.7.2 fails to load after update of numba to 0.50
librosa/librosa#1160
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)