Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xxe-pe: init at 9.4.0 #95593

Merged
merged 1 commit into from Aug 20, 2020
Merged

xxe-pe: init at 9.4.0 #95593

merged 1 commit into from Aug 20, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 16, 2020

Motivation for this change

Add a proprietary DocBook editor free for personal use.

https://www.xmlmind.com/xmleditor/

Based on ghidra derivation. Would prefer to use openjdk14 as that is what the installation guide shows but that seems to need to be built from scratch (including webkit:exclamation:), the guide also says Java 8+ is needed so openjdk11 should be fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
xxe-pe: init at 9.4.0
966c2ed 
Add a proprietary DocBook editor free for personal use.

https://www.xmlmind.com/xmleditor/
@jtojnar jtojnar mentioned this pull request Aug 17, 2020
Merged
10 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 17, 2020

I recommend opening Preferences from the Options in menu bar, and in the Save pane, setting indentation to 1 and max line length to 999999999 to minimize the Nixpkgs diffs.

worldofpeace
worldofpeace approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM worked

@worldofpeace worldofpeace merged commit bb67a84 into NixOS:master Aug 20, 2020
@jtojnar jtojnar deleted the xxe-pe branch August 20, 2020 21:07
@jtojnar jtojnar mentioned this pull request Nov 20, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @worldofpeace