Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openrct2: 0.2.6 -> 0.3.0 #95533

Merged
merged 1 commit into from Aug 16, 2020
Merged

openrct2: 0.2.6 -> 0.3.0 #95533

merged 1 commit into from Aug 16, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Aug 15, 2020

Motivation for this change

Update OpenRCT2 to its latest, just released version 0.3.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

endgame
endgame approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Tested on NixOS with:

nix-build -A openrct2 https://github.com/oxzi/nixpkgs/archive/4be616d51e9e42e054ebdfb29947a66f761063a4.tar.gz

Booted it up but I don't have RC2 files so there's nothing more I can test.

jonringer
jonringer approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage
dont have copy of rct2 to test full, but it appears to work

https://github.com/NixOS/nixpkgs/pull/95533
1 package built:
openrct2

@jonringer jonringer merged commit 4789d6f into NixOS:master Aug 16, 2020
@oxzi oxzi deleted the openrct2-v0.3.0 branch August 16, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endgame endgame endgame approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @endgame @jonringer