Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[haskell-updates] haskellPackages.haskell-language-server: 0.2.0 -> 0.3.0 #95585

Merged
merged 1 commit into from Aug 16, 2020
Merged

[haskell-updates] haskellPackages.haskell-language-server: 0.2.0 -> 0.3.0 #95585

merged 1 commit into from Aug 16, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Aug 16, 2020 •
edited

While we are at it I:

  • Disable tests, because I can‘t keep up with the speed hls introduces
    more tests that cause trouble in nixpkgs.
  • Fix builds of fourmolu and retrie
  • Remove the wrapper for hls which is obsolete because of improved
    package detection in hie-bios. And added a note that this can be removed
    for ghcide soon, too.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
haskellPackages.haskell-language-server: 0.2.0 -> 0.3.0
af017c4 
While we are at it I:
* Disable tests, because I can‘t keep up with the speed hls introduces
more tests that cause trouble in nixpkgs.
* Fix builds of fourmolu and retrie
* Remove the wrapper for hls which is obsolete because of improved
package detection in hie-bios. And added a note that this can be removed
for ghcide soon, too.
@maralorn
Copy link
Member Author

maralorn commented Aug 16, 2020 •
edited

Thx for the quick review. I'll merge when the tests pass.

@GrahamcOfBorg build haskellPackages.retrie
@GrahamcOfBorg build haskellPackages.fourmolu
@GrahamcOfBorg build haskellPackages.haskell-language-server

@maralorn maralorn merged commit c8e5633 into NixOS:haskell-updates Aug 16, 2020
@maralorn maralorn deleted the bump-hls branch August 16, 2020 14:47
@sir4ur0n sir4ur0n mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout