Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/test-instrumentation.nix: Fix evaluation error #95584

Merged
merged 1 commit into from Aug 16, 2020
Merged

nixos/test-instrumentation.nix: Fix evaluation error #95584

merged 1 commit into from Aug 16, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Aug 16, 2020

Discovered via #82743 which
improved option checking, causing an evaluation error that was
hard to understand without running the evaluation manually.

Motivation for this change

Unblock hydra caused by fixed option checking in #82743

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
nixos/test-instrumentation.nix: Fix evaluation error
2578557 
Discovered via NixOS#82743 which
improved option checking, causing an evaluation error that was
hard to understand without running the evaluation manually.
@roberth roberth requested a review from samueldr August 16, 2020 11:58
@roberth
Copy link
Member Author

roberth commented Aug 16, 2020

Will merge and trigger hydra

@roberth roberth merged commit cf568e3 into NixOS:master Aug 16, 2020
@infinisil infinisil mentioned this pull request Aug 17, 2020
Merged
4 tasks
@Ma27
Copy link
Member

Ma27 commented Aug 18, 2020

This condition is not quite correct unfortunately as options points to lib.options here due to with lib;. See #95743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberth @Ma27