Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-direnv: 1.0.0 -> 1.1 #95586

Merged
merged 1 commit into from Aug 16, 2020
Merged

nix-direnv: 1.0.0 -> 1.1 #95586

merged 1 commit into from Aug 16, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 16, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title bitwarden_rs: make EnvironmentFile mergeable nix-direnv: 1.0.0 -> 1.1 Aug 16, 2020
@Mic92 Mic92 requested a review from colemickens August 16, 2020 12:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-direnv-1-1rc1-released-flake-support/8526/9

@Ma27 Ma27 merged commit d91785c into NixOS:master Aug 16, 2020
@Mic92 Mic92 deleted the nix-direnv branch August 16, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemickens colemickens Awaiting requested review from colemickens

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @nixos-discourse @Ma27