New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r20.03] sigil: 0.9.14 -> 0.9.16, addressing CVE-2019-14452 #95583
[r20.03] sigil: 0.9.14 -> 0.9.16, addressing CVE-2019-14452 #95583
Conversation
addressing CVE-2019-14452
Builds, but segfaults for me.
Result of 1 package built:- sigil |
|
Incidentally, does the existing 0.9.14 work for you without crashing? |
Yes, it does. |
@mweinelt So to just be sure, this one fails (that's
While this one succeeds (that's from this PR):
Is that correct? |
#95583 crashes.
#95873 crashes.
release-20.03 crashes as well.
|
@mweinelt Which version worked for you in #95583 (comment) then? |
I think that was 0.9.14 from master :/ |
Alright, then this PR didn't break it for wayland, because it never worked on 20.03 anyways. @mweinelt I believe you mistakenly answered in #95583 (comment) then, because the current version on master isn't 0.9.14 but rather 1.3.0. For the future please make sure to compare PRs against the base branch and not master :) |
Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2019-14452
Seems to work fine, tested non-nixos linux x86_64.
master
bumped in #95537Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)