Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r20.03] pythonPackages.asyncpg: add patch for CVE-2020-17446 #95518

Merged
merged 1 commit into from Aug 16, 2020
Merged

[r20.03] pythonPackages.asyncpg: add patch for CVE-2020-17446 #95518

merged 1 commit into from Aug 16, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 15, 2020 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-17446

master has already been bumped for the fix (#95499)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Aug 15, 2020

@ofborg eval build python37Packages.asyncpg python38Packages.asyncpg python38Packages.orm python37Packages.fastapi python37Packages.starlette

@ofborg ofborg bot requested a review from eadwu August 15, 2020 19:44
@mweinelt
Copy link
Member

mweinelt commented Aug 16, 2020 •
edited

This is taking a while since nixpkgs-review is running the python3.8-uvloop-0.14.0 testsuite 🙄. (Edit: and got stuck twice already)

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95518 1

5 packages failed to build:
- python38Packages.asyncpg
- python38Packages.databases
- python38Packages.fastapi
- python38Packages.orm
- python38Packages.starlette
6 packages built:
- python37Packages.asyncpg
- python37Packages.databases
- python37Packages.fastapi
- python37Packages.orm
- python37Packages.starlette
- sourcehut.listssrht

@mweinelt
Copy link
Member

mweinelt commented Aug 16, 2020 •
edited 

builder for '/nix/store/0xh5sa93ka8ymhcf1s723i5ilh3syizr-python3.8-uvloop-0.14.0.drv' failed with exit code 1; last 10 log lines:
  tests/test_dealloc.py .
  tests/test_dns.py ....................s..............................
  tests/test_executors.py ....
  tests/test_pipes.py ..........
  tests/test_process.py ..............................................................
  tests/test_process_spawning.py .
  tests/test_regr1.py .
  tests/test_signals.py s...................
  tests/test_sockets.py ..............s............s.....
  client_loop: send disconnect: Broken pipe
cannot build derivation '/nix/store/1yfhfc2j85pd7mq61hah1pizndvxk10c-python3.8-asyncpg-0.20.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/08d1x8146bfcgw2dh5h9ijklrdafacpf-python3.8-uvicorn-0.11.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kmh0m3brp3yp62rr404nhqfxgdgql50r-python3.8-databases-0.2.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4fys5g6v9gchqan7jlq1n1p6bziyr8f2-python3.8-orm-0.1.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yjqgl8w5hw2l03cc926m5v9d1bi8dapq-python3.8-starlette-0.12.9.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/n2qq7kv3vn8350byaxak68lbz86w0ha9-python3.8-fastapi-0.49.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/w5jd2rcqm0rq7di97khdm9xw3kn01152-env.drv': 5 dependencies couldn't be built

MagicStack/uvloop#355 (comment)

@mweinelt mweinelt requested a review from costrouc August 16, 2020 12:53
@mweinelt mweinelt mentioned this pull request Aug 16, 2020
Merged
10 tasks
@mweinelt
Copy link
Member

I've proposed #95591 as a granular fix for uvloop that we can port to stable. Maybe you can take a look?

@mweinelt mweinelt mentioned this pull request Aug 16, 2020
Merged
10 tasks
@risicle risicle force-pushed the ris-asyncpg-CVE-2020-17446-r20.03 branch from 3e59b14 to 24e7620 Compare August 16, 2020 18:19
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95518 1

11 packages built:
- python37Packages.asyncpg
- python37Packages.databases
- python37Packages.fastapi
- python37Packages.orm
- python37Packages.starlette
- python38Packages.asyncpg
- python38Packages.databases
- python38Packages.fastapi
- python38Packages.orm
- python38Packages.starlette
- sourcehut.listssrht

@mweinelt mweinelt merged commit 9319284 into NixOS:release-20.03 Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

@eadwu eadwu Awaiting requested review from eadwu

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @mweinelt