Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.elementpath: 1.4.6 -> 2.0.0 #95529

Merged
merged 2 commits into from Aug 15, 2020
Merged

python3Packages.elementpath: 1.4.6 -> 2.0.0 #95529

merged 2 commits into from Aug 15, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 15, 2020 •
edited

Motivation for this change

noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/95529
8 packages built:
python37Packages.elementpath python37Packages.fints python37Packages.sepaxml python37Packages.xmlschema python38Packages.elementpath python38Packages.fints python38Packages.sepaxml python38Packages.xmlschema

@jonringer jonringer requested a review from FRidh as a code owner August 15, 2020 20:05
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95529 1

8 packages built:
- python37Packages.elementpath
- python37Packages.fints
- python37Packages.sepaxml
- python37Packages.xmlschema
- python38Packages.elementpath
- python38Packages.fints
- python38Packages.sepaxml
- python38Packages.xmlschema

@mweinelt mweinelt merged commit e691019 into NixOS:master Aug 15, 2020
@jonringer jonringer deleted the bump-elementpath branch August 15, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt