Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] python3Packages.uvloop: disable test_write_to_closed_transport test on 3.8+ #95608

Merged
merged 1 commit into from Aug 16, 2020
Merged

[20.03] python3Packages.uvloop: disable test_write_to_closed_transport test on 3.8+ #95608

merged 1 commit into from Aug 16, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

Reenables the TCP testsuite and only disables the single failing test.

MagicStack/uvloop#355
(cherry picked from commit affa772)

Blocks #95518

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
python3Packages.uvloop: disable test_write_to_closed_transport test o…
123ff2f 
…n 3.8+

Reenables the TCP testsuite and only disables the single failing test.

MagicStack/uvloop#355
(cherry picked from commit affa772)
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 95608 1

9 packages built:
- python38Packages.aiorun
- python38Packages.asyncpg
- python38Packages.databases
- python38Packages.fastapi
- python38Packages.httpx
- python38Packages.orm
- python38Packages.starlette
- python38Packages.uvicorn
- python38Packages.uvloop

jonringer
jonringer approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95608 1

9 packages built:
- python38Packages.aiorun
- python38Packages.asyncpg
- python38Packages.databases
- python38Packages.fastapi
- python38Packages.httpx
- python38Packages.orm
- python38Packages.starlette
- python38Packages.uvicorn
- python38Packages.uvloop

@jonringer jonringer merged commit f8a10a7 into NixOS:release-20.03 Aug 16, 2020
@mweinelt mweinelt deleted the 20.03/uvloop branch August 16, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @jonringer