Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dask: ignore flaky test #95612

Merged
merged 1 commit into from Aug 18, 2020
Merged

python3Packages.dask: ignore flaky test #95612

merged 1 commit into from Aug 18, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 16, 2020 •
edited

Motivation for this change

noticed it fails in-deterministically. If I rerun the build enough time, it will eventually pass.

It spawns 3 workers that are meant to sleep for .5s and then the assertion will fail as there will be less than that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 16, 2020 18:42
drewrisinger
drewrisinger approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rationale seems sound.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review -p python37Packages.dask -p python38Packages.dask (didn't attempt all):
2 packages built:
python37Packages.dask python38Packages.dask

@jonringer jonringer merged commit 8a9f58a into NixOS:master Aug 18, 2020
@jonringer jonringer deleted the fix-dask-tests branch August 18, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @drewrisinger