python3Packages.uvloop: disable test_write_to_closed_transport test on 3.8+ #95591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 3.8+ Reenables the TCP testsuite and only disables the single failing test. MagicStack/uvloop#355
mweinelt
added
the
9.needs: port to stable
10 tasks
risicle
approved these changes
Aug 16, 2020
There was a problem hiding this comment.
WFM non-nixos linux x86_64 (not done a full rebuild as it's just a test change)
FWIW there are a few painful time-based tests in test_base.py too which fail for me on darwin simply because it's not generous enough with its time budget. But I don't think that's anything new.
|
I ran into some issues with it hanging yesterday as well |
jonringer
approved these changes
Aug 16, 2020
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/95591
6 packages failed to build:
python37Packages.fastapi python37Packages.qasm2image python37Packages.qiskit python38Packages.fastapi python38Packages.qasm2image python38Packages.qiskit
41 packages built:
cura datasette gns3-gui gns3-server google-music-scripts mtprotoproxy octoprint python37Packages.aiorun python37Packages.asyncpg python37Packages.databases python37Packages.datasette python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.google-music python37Packages.httpx python37Packages.orm python37Packages.pproxy python37Packages.qiskit-ibmq-provider python37Packages.sanic python37Packages.sanic-auth python37Packages.sentry-sdk python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.aiorun python38Packages.asyncpg python38Packages.databases python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.google-music python38Packages.httpx python38Packages.orm python38Packages.pproxy python38Packages.qiskit-ibmq-provider python38Packages.sanic python38Packages.sanic-auth python38Packages.sentry-sdk python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Reenables the TCP testsuite and only disables the single failing test.
MagicStack/uvloop#355
Noticed the breakage in #95518 (comment) and wondered why master was not affected.
The port to stable blocks #95518.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)