Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noisetorch: init at 0.5.1-beta #93480

Merged
merged 2 commits into from Jul 21, 2020
Merged

noisetorch: init at 0.5.1-beta #93480

merged 2 commits into from Jul 21, 2020

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented Jul 19, 2020

Motivation for this change

Add NoiseTorch program. https://github.com/lawl/NoiseTorch

fixes #93417

Things done
  • [ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit July 20, 2020 03:29
danieldk
danieldk suggested changes Jul 20, 2020
View reviewed changes
pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
@JJJollyjim
Copy link
Member

JJJollyjim commented Jul 21, 2020 •
edited

Tested the derivation on non-nixos, does what it says (though my voice is very hard to make out, the noise is gone :)

danieldk
danieldk suggested changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! This looks almost ready to be merged. Two more small requested changes.

pkgs/applications/audio/noisetorch/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/rnnoise-plugin/default.nix Outdated Show resolved Hide resolved
@PanAeon
Copy link
Contributor Author

PanAeon commented Jul 21, 2020

@danieldk done)

@danieldk
Copy link
Contributor

I pushed some more cleanups:

  • One commit per new derivation, with a message that follows the contribution guidelines.
  • name -> pname
  • Format with nixpkgs-fmt.

Let's see if ofborg is happy.

@danieldk danieldk changed the title add noisetorch noisetorch: init at 0.5.1-beta Jul 21, 2020
@danieldk
Copy link
Contributor

@ofborg build noisetorch

danieldk
danieldk approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 93480 1

2 packages built:
- noisetorch
- rnnoise-plugin

@danieldk danieldk merged commit 5507932 into NixOS:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoiseTorch
3 participants
@PanAeon @JJJollyjim @danieldk