Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play-with-mpv: init at 2020-05-18 #93473

Merged
merged 3 commits into from Mar 31, 2021
Merged

play-with-mpv: init at 2020-05-18 #93473

merged 3 commits into from Mar 31, 2021

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change

Adds play-with-mpv, which allows using this extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jul 19, 2020

i think firefox has a similar extension too.

@stale
Copy link

stale bot commented Jan 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 16, 2021
SuperSandro2000
SuperSandro2000 requested changes Mar 21, 2021
View reviewed changes
pkgs/tools/video/play-with-mpv/default.nix Outdated Show resolved Hide resolved
pkgs/tools/video/play-with-mpv/default.nix Outdated Show resolved Hide resolved
@jbalme jbalme mentioned this pull request Mar 24, 2021
Closed
@dawidsowa @SuperSandro2000
!fixup play-with-mpv: init at 2020-05-18
ae81d20 
Apply suggestions from code review

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 24, 2021
@dawidsowa @SuperSandro2000
!fixup play-with-mpv: init at 2020-05-18
dadad73 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit 7b02aca into NixOS:master Mar 31, 2021
@dawidsowa dawidsowa deleted the play_with_mpv branch March 31, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidsowa @teto @SuperSandro2000