Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.pygobject3: 3.36.0 → 3.36.1 #93492

Merged
merged 1 commit into from Jul 22, 2020
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jul 20, 2020

Motivation for this change

This won’t get picked up by r-ryantm.

Changes look okay:

3.36.1 - 2020-05-06

  • tests: Fix failing tests with pytest 5.4.0+
  • Gtk: Add override to make sure both TreeModelSort.new_with_model and
    TreeModel.sort_new_with_model exist independend of the gtk version
  • Gtk.Template: Fix initialisation order errors with Widgets getting created from C
    (potentially through other templates) :issue:257 :issue:386 :issue:341 :mr:140 (:user:Jean Felder <jfelder>)
  • Gtk.Template: Fix errors when calling init_template() multiple times :mr:140 (:user:Jean Felder <jfelder>)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar changed the base branch from master to staging July 20, 2020 00:15
@jtojnar jtojnar requested a review from ttuegel as a code owner July 20, 2020 00:15
@jtojnar jtojnar changed the base branch from staging to master July 20, 2020 00:19
@jtojnar jtojnar changed the base branch from master to staging July 20, 2020 00:19
@jtojnar jtojnar removed the request for review from ttuegel July 20, 2020 00:19
@FRidh FRidh merged commit a2522c8 into NixOS:staging Jul 22, 2020
@jtojnar jtojnar deleted the pygi-3.36.1 branch September 2, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants