Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Resilio Sync directory_root option to config root, fixes #93460 #93512

Closed
wants to merge 1 commit into from
Closed

move Resilio Sync directory_root option to config root, fixes #93460 #93512

wants to merge 1 commit into from

Conversation

juskrey
Copy link

@juskrey juskrey commented Jul 20, 2020

Motivation for this change

Resilio Sync config generation was invalid, at least for Resilio SYnc versions 2.6+

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@juskrey juskrey changed the title move directory_root option to config root, fixes #93460 move Resilio Sync directory_root option to config root, fixes #93460 Jul 20, 2020
@danieldk
Copy link
Contributor

danieldk commented Jul 20, 2020 •
edited

Thanks for the contribution! This is a dupe of #85689. Seems like I accidentally closed it 14 days ago.

@danieldk danieldk closed this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juskrey @danieldk @Janik-Haag