Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pc-ble-driver-py: fix Darwin build #93490

Merged
merged 1 commit into from Jul 27, 2020
Merged

python3Packages.pc-ble-driver-py: fix Darwin build #93490

merged 1 commit into from Jul 27, 2020

Conversation

siriobalmelli
Copy link
Contributor

Motivation for this change

Build nrfutil on Darwin.

Note that this depends on #93487

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli siriobalmelli mentioned this pull request Jul 19, 2020
Merged
10 tasks
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Jul 19, 2020
@ofborg ofborg bot requested a review from gebner July 19, 2020 22:02
@siriobalmelli
python3Packages.pc-ble-driver-py: fix Darwin build
2db3a7e 
Remove udev dependency, propagate it from pc-ble-driver.
On Darwin, IOKit is propagated instead.

Depends on d6b3707

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@LnL7 LnL7 merged commit 5e4c9da into NixOS:master Jul 27, 2020
@siriobalmelli siriobalmelli deleted the fix/pc-ble-driver-py branch July 28, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siriobalmelli @LnL7