Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediainfo-gui: use gtk3 #93502

Merged
merged 1 commit into from Jul 20, 2020
Merged

mediainfo-gui: use gtk3 #93502

merged 1 commit into from Jul 20, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

We were compiling against an old wxgtk that pulled in gtk2. Instead use
a more recent version compiled against gtk3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from devhell July 20, 2020 04:20
devhell
devhell approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@devhell devhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@peterhoeg peterhoeg merged commit e8388cb into master Jul 20, 2020
@peterhoeg peterhoeg deleted the f/mediainfo branch July 20, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhell devhell devhell approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @devhell