Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blas: do not report an empty line for every checked symbol #93475

Merged
merged 1 commit into from Jul 22, 2020
Merged

blas: do not report an empty line for every checked symbol #93475

merged 1 commit into from Jul 22, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Small annoyance when testing a new BLAS provider.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel July 19, 2020 13:35
@danieldk danieldk changed the base branch from master to staging July 20, 2020 06:44
@danieldk
Copy link
Contributor Author

Rebased onto staging.

@ofborg ofborg bot requested a review from ttuegel July 20, 2020 06:58
@danieldk
Copy link
Contributor Author

danieldk commented Jul 22, 2020 •
edited

@ttuegel (and @hmenke) thanks for the review! Can I just merge this into staging or should I wait until one of the staging maintainers picks this up?

@FRidh FRidh merged commit 68bd1c8 into NixOS:staging Jul 22, 2020
@FRidh
Copy link
Member

FRidh commented Jul 22, 2020

@danieldk yes feel free to merge into staging like you do with master.

@danieldk danieldk deleted the blas-no-newlines branch August 17, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@andir andir Awaiting requested review from andir

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @FRidh @ttuegel @hmenke