Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break-time: init at 0.1.1 #93476

Merged
merged 1 commit into from Jul 20, 2020
Merged

break-time: init at 0.1.1 #93476

merged 1 commit into from Jul 20, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Jul 19, 2020 •
edited

Motivation for this change

Adds break-time, an app that forces you to take breaks from your computer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build break-time

danieldk
danieldk approved these changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 93476 1

1 package built:
- break-time

Also seems to work. I don't get a systray icon though (GNOME 3), even though I use the appindicator extension.

pkgs/applications/misc/break-time/default.nix Outdated
openssl
];

cargoSha256 = "0brmgrxhspcpcarm4lvnl95dw2n96r20w736giv18xcg7d5jmgca";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be more customary to put cargoSha256 immediately after src.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I changed the location of cargoSha256 immediately under src in f1d3856.

@cdepillabout cdepillabout merged commit c32264e into NixOS:master Jul 20, 2020
@cdepillabout cdepillabout deleted the add-break-time branch July 20, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @danieldk