Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istioctl: init at 1.6.5 #93484

Merged
merged 1 commit into from Jul 20, 2020
Merged

istioctl: init at 1.6.5 #93484

merged 1 commit into from Jul 20, 2020

Conversation

veehaitch
Copy link
Member

Motivation for this change

Istio configuration command line utility for service operators to debug and diagnose their Istio mesh

The binary is statically linked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty straightforward Go project:

$ istioctl/cmd/istioctl
$ go build
$ ls -l istioctl
-rwxr-xr-x 1 daniel users 123085651 Jul 20 17:20 istioctl

So, this could just be built with buildGoModule or buildGoPackage. Building from source is highly preferred over packaging binaries.

@veehaitch
Copy link
Member Author

This seems like a pretty straightforward Go project:

$ istioctl/cmd/istioctl
$ go build
$ ls -l istioctl
-rwxr-xr-x 1 daniel users 123085651 Jul 20 17:20 istioctl

So, this could just be built with buildGoModule or buildGoPackage. Building from source is highly preferred over packaging binaries.

Agreed and adapted! The binary is pretty huge though.`

$ du -ah (which istioctl)
101M	/nix/store/sxzlfz98ha3fwgp7831yc56zcdhb2hdn-istioctl-1.6.5/bin/istioctl

@ofborg ofborg bot requested a review from kalbasit July 20, 2020 16:31
@danieldk
Copy link
Contributor

Agreed and adapted!

Awesome 👍

The binary is pretty huge though.`

$ du -ah (which istioctl)
101M	/nix/store/sxzlfz98ha3fwgp7831yc56zcdhb2hdn-istioctl-1.6.5/bin/istioctl

Strange. Here it's much smaller:

$ du -am `which istioctl`
36	/nix/store/kpzlm3vgbbs7s99sr4781z9phvc71nwa-istioctl-1.6.5/bin/istioctl

danieldk
danieldk approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Result of nixpkgs-review pr 93484 1

1 package built:
- istioctl

@danieldk danieldk merged commit 29711bb into NixOS:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veehaitch @danieldk