Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dbus-python: 1.2.12 -> 1.2.16 #93519

Merged
merged 1 commit into from Jul 22, 2020
Merged

pythonPackages.dbus-python: 1.2.12 -> 1.2.16 #93519

merged 1 commit into from Jul 22, 2020

Conversation

romanofski
Copy link
Contributor

@romanofski romanofski commented Jul 20, 2020 •
edited

This upgrades dbus-python to the 1.2.16 release. Reason for this version
upgrade is a the failing hamster application (see. programs.hamster).
With a 1.2.12 dbus-python version hamster can not start and fails with:

Traceback (most recent call last):
  File "/nix/store/5ax21lyiprc9v5l3pl7dbfr2hqbrh970-hamster-3.0.2/bin/.hamster-wrapped", line 41, in <module>
    from hamster import client, reports
  File "/nix/store/5ax21lyiprc9v5l3pl7dbfr2hqbrh970-hamster-3.0.2/lib/python3.8/site-packages/hamster/client.py", line 46, in <module>
    assert not (
AssertionError: python3.8 changed str(<dbus integers>).
   That broke hamster (https://github.com/projecthamster/hamster/issues/477).
   Please upgrade to dbus-python >= 1.2.14.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romanofski
pythonPackages.dbus-python: 1.2.12 -> 1.2.16
2f5ecb3 
This upgrades dbus-python to the 1.2.16 release. Reason for this version
upgrade is a the failing hamster application (see. programs.hamster).
With a 1.2.12 dbus-python version hamster can not start and fails with:

    Traceback (most recent call last):
      File "/nix/store/5ax21lyiprc9v5l3pl7dbfr2hqbrh970-hamster-3.0.2/bin/.hamster-wrapped", line 41, in <module>
        from hamster import client, reports
      File "/nix/store/5ax21lyiprc9v5l3pl7dbfr2hqbrh970-hamster-3.0.2/lib/python3.8/site-packages/hamster/client.py", line 46, in <module>
        assert not (
    AssertionError: python3.8 changed str(<dbus integers>).
       That broke hamster (projecthamster/hamster#477).
       Please upgrade to dbus-python >= 1.2.14.
@FRidh FRidh changed the base branch from master to staging July 22, 2020 14:49
@FRidh FRidh changed the base branch from staging to master July 22, 2020 14:51
@FRidh FRidh changed the base branch from master to staging July 22, 2020 14:51
@FRidh FRidh merged commit cd7a405 into NixOS:staging Jul 22, 2020
@romanofski romanofski deleted the fix/dbus-python-version branch July 22, 2020 21:02
romanofski added a commit to romanofski/nix that referenced this pull request Aug 8, 2020
@romanofski
Start and use hamster time tracker
ceafa6c 
Until:

   NixOS/nixpkgs#93519

is merged, we bump the dbus-python version with an overlay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romanofski @FRidh @Janik-Haag