Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tensorflow (binary) to version 2.2.0 #95736

Closed
wants to merge 5 commits into from
Closed

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Aug 18, 2020

This PR contains work by @vladmaraev which I submit with his consent.

Motivation for this change

Upstream upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Aug 18, 2020

@ofborg eval

@jyp jyp force-pushed the tf-2.2 branch 2 times, most recently from cc191aa to 92b023a Compare August 18, 2020 11:50
homepage = https://github.com/tensorflow/addons;
description = "Useful extra functionality for TensorFlow 2.x maintained by SIG-addons";
license = lib.licenses.bsd3;
maintainers = with lib.maintainers; [ vladmaraev ];
Copy link
Contributor

@jonringer jonringer Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add maintainer in a separate commit

maintainers: add <name>
undefined variable 'vladmaraev' at /var/lib/ofborg/checkout/rep

};

# Tests require too many extra dependencies
doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.

@drewrisinger drewrisinger mentioned this pull request Aug 20, 2020
10 tasks
@mkg20001
Copy link
Member

mkg20001 commented Oct 1, 2020

I've rebased my current PR to upgrade to 2.3.0 against this one. See #98522

Additionally it includes a change to the update script so it no longer requires manually entering the URLs

@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@NickCao
Copy link
Member

NickCao commented Jan 26, 2023

superseded by later updates,

@NickCao NickCao closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants