Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openambit: init at 0.5 #95706

Closed
wants to merge 1 commit into from
Closed

openambit: init at 0.5 #95706

wants to merge 1 commit into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Aug 17, 2020

Motivation for this change

To package openambit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee
Copy link
Member Author

rycee commented Aug 17, 2020

@GrahamcOfBorg build openambit

@rycee rycee force-pushed the pkg/openambit branch 2 times, most recently from 2e8ef2c to 5f8345d Compare August 17, 2020 19:47
drewrisinger
drewrisinger suggested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff needs some work. See comments below, mostly related to qt5 apps
  • Commits style LGTM
  • Builds via nix-review

pkgs/applications/misc/openambit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openambit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openambit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openambit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openambit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/openambit/default.nix Show resolved Hide resolved
pkgs/applications/misc/openambit/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

Forgot to mention, if there's any sort of test that you could run/include to check that it's working properly, that'd be highly appreciated. Adding something like a checkPhase that just checks that the version outputs or anything.

@rycee
Copy link
Member Author

rycee commented Sep 4, 2020

Thanks for the review @drewrisinger! Rebased updated version to master in ee7e23f.

@rycee rycee closed this Sep 4, 2020
@rycee rycee deleted the pkg/openambit branch September 4, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rycee @drewrisinger