Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: prefer VMS with 'big-parallel' #95721

Closed
wants to merge 1 commit into from
Closed

chromium: prefer VMS with 'big-parallel' #95721

wants to merge 1 commit into from
+2 −0

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 17, 2020 •
edited

Motivation for this change

IIRC, hydra's "big-parallel" machines have 32 cores instead of 2. Should help with ~60 hr build times. Unless this causes timeout/OOm issues

may close: #81081

related: #78347

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

primeos
primeos reviewed Aug 18, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already set for chromium.browser (the real build, chromium is just the wrapper) in browser.nix. AFAIK that should be sufficient (but I never verified if it actually works as expected).

@jonringer
Copy link
Contributor Author

ah didn't realize. The chromium derivation is hard to tell what's going on, there's 3 files which facilitate it's existence.

@jonringer jonringer closed this Aug 18, 2020
@jonringer jonringer deleted the chromium-hydra branch September 28, 2020 18:52
@collares
Copy link
Member

But does ungoogled-chromium inherit the same setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos left review comments

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

@bendlas bendlas Awaiting requested review from bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixpkgs-unstable release channel 2-4 days out-of-sync from hydra
3 participants
@jonringer @collares @primeos