Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyterhub: fix authenticator configuration #95715

Merged
merged 1 commit into from Aug 25, 2020
Merged

jupyterhub: fix authenticator configuration #95715

merged 1 commit into from Aug 25, 2020

Conversation

aborsu
Copy link
Contributor

@aborsu aborsu commented Aug 17, 2020 •
edited

authentication_class is invalid, it should be authenticator_class cfr project documentation

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aborsu
jupyterhub: fix authenticator configuration
b5ab876 
authentication_class  is invalid, it should be authenticator_class cfr [project doc|https://tljh.jupyter.org/en/latest/topic/authenticator-configuration.html]
@aborsu aborsu requested a review from costrouc August 18, 2020 08:41
costrouc
costrouc approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aborsu good catch. I was using the default authenticator class for testing and is why I did not see this issue. Thanks for finding that!

@aborsu
Copy link
Contributor Author

aborsu commented Aug 25, 2020

@FRidh you merged the last one?

@FRidh FRidh merged commit 19a7012 into NixOS:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costrouc costrouc costrouc approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aborsu @costrouc @FRidh