Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p4v: 2017.3.1601999 -> 2020.1.1966006 #95748

Merged
merged 2 commits into from Aug 20, 2020
Merged

p4v: 2017.3.1601999 -> 2020.1.1966006 #95748

merged 2 commits into from Aug 20, 2020

Conversation

corngood
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@corngood corngood mentioned this pull request Aug 18, 2020
Closed
10 tasks
nioncode
nioncode approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@nioncode nioncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for taking this over from my failed attempts.

veprbl
veprbl approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patchelfUnstable is currently not used anywhere in the nixpkgs, so it should be okay to update.

@veprbl veprbl merged commit 86b9caf into NixOS:master Aug 20, 2020
@corngood
Copy link
Contributor Author

I've also made a PR to add the p4 command line tools: #95103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@nioncode nioncode nioncode approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nathyong nathyong Awaiting requested review from nathyong

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corngood @veprbl @nioncode