Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump a few packages related to the Matrix ecosystem #95708

Merged
merged 4 commits into from Aug 18, 2020
Merged

Bump a few packages related to the Matrix ecosystem #95708

merged 4 commits into from Aug 18, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 17, 2020
@ofborg ofborg bot requested a review from Ralith August 17, 2020 19:06
@jonringer
Copy link
Contributor

@GrahamcOfBorg test matrix-synapse

jonringer
jonringer approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/95708
8 packages built:
element-desktop element-web matrix-synapse matrixcli python37Packages.canonicaljson python37Packages.signedjson python38Packages.canonicaljson python38Packages.signedjson

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 95708 1

7 packages built:
- element-desktop
- matrix-synapse
- matrixcli
- python37Packages.canonicaljson
- python37Packages.signedjson
- python38Packages.canonicaljson
- python38Packages.signedjson

@mweinelt mweinelt merged commit 6622ba5 into NixOS:master Aug 18, 2020
@Ma27 Ma27 deleted the matrix-updates branch August 18, 2020 12:19
@Ma27
Copy link
Member Author

Ma27 commented Aug 18, 2020

Ported to stable as 43e1155, 32324de, af10ede, f0924db.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@jonringer jonringer jonringer approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

@mguentner mguentner Awaiting requested review from mguentner

@fadenb fadenb Awaiting requested review from fadenb

@pacien pacien Awaiting requested review from pacien

@FRidh FRidh Awaiting requested review from FRidh

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @jonringer @mweinelt