Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chamber: init at 2.8.2 #95745

Merged
merged 2 commits into from Aug 20, 2020
Merged

chamber: init at 2.8.2 #95745

merged 2 commits into from Aug 20, 2020

Conversation

kalekseev
Copy link
Contributor

@kalekseev kalekseev commented Aug 18, 2020 •
edited

Motivation for this change

Chamber is a tool for managing secrets. Currently it does so by storing secrets in SSM Parameter Store, an AWS service for storing secrets.
Basic use case is that you want to allow some IAM role to run service that require configuration, chamber helps manage config params in AWS SSM so iam user can start service by passing config from SSM, eg: aws-vault exec development -- chamber exec loadbalancers -- nginx

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit August 18, 2020 12:11
zowoq
zowoq reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise lgtm.

maintainers/maintainer-list.nix Show resolved Hide resolved
@kalekseev
Copy link
Contributor Author

One nit, otherwise lgtm.

I made a separate commit for maintainer info, thanks!

@zowoq zowoq merged commit 21ec917 into NixOS:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalekseev @zowoq