nixos/dovecot: Improve mailboxes type #95722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
approved these changes
Aug 18, 2020
The previous use of types.either disallowed assigning a list at one point and an attrset an another.
infinisil
force-pushed
the
dovecot-mailboxes-improved
branch
from
c2a5025
to
fc121e2
Compare
|
Just noticed that this can be simplified a bit, pushed that now (and tested again it works for my setup). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The previous use of
types.eitherdisallowed assigning a list at one point and an attrset an another. This fixes this plus some other improvements like:config.services.dovecot2.mailboxesbe an attrset instead of a list, by not usingapplyI couldn't easily keep the informative
nameassignment error, so I removed that in favor ofnamebeingreadOnly(meaning it can only be assigned once, which is already done in the module itself).Ping @Ma27 and @nlewo from the PR that introduced mailboxes as attrsets (nice!) #89486
Things done
Tested with https://gitlab.com/simple-nixos-mailserver/nixos-mailserver (which uses a list to assign mailboxes) and some custom mailboxes in my own config (which uses an attrset).