periph: add a ConstantMap container for configuration constants. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
Aug 17, 2020
nmigen_soc/periph.py
Outdated
| class ConstantMap(Mapping): | ||
| """Named constant map. | ||
|
|
||
| A read-only container for named constants. Keys are iterated in ascending order. |
There was a problem hiding this comment.
I don't have a strong opinion on this, but I feel like insertion order would be more useful--this way the order of constants in the BSP matches the order of constants in peripheral code. This would matter for few people (most won't be looking at raw BSP sources), but it still seems nice; on the other hand, any deterministic iteration order is fine reproducibility-wise.
|
Thanks! Turns out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24.