Duplicity fix b2 backend #95714
Merged
Duplicity fix b2 backend #95714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
force-pushed
the
duplicity-fix-b2-backend
branch
from
97ba2cb
to
af8d34d
Compare
jonringer
reviewed
Aug 17, 2020
| meta = with stdenv.lib; { | ||
| description = "Client library and utilities for access to B2 Cloud Storage (backblaze)."; | ||
| homepage = "https://github.com/Backblaze/b2-sdk-python"; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
please add yourself as maintainer
There was a problem hiding this comment.
To clarify, I have no interest in manually maintaining random python libraries that should be autogenerated from lock files. If the pythonPackages maintainers think that is the best way to use maintainer time, they can do that of course.
There was a problem hiding this comment.
Lock files have their own negatives such as a closure size and large lock files which need to be committed, pretty much they are only good for developer time.
And python specifically has such low average release management quality per package they need to be manually patched to make them more usable.
thoughts @FRidh ?
10 tasks
Profpatsch
force-pushed
the
duplicity-fix-b2-backend
branch
from
af8d34d
to
0e1b86a
Compare
The backblaze library moved into the b2sdk package. If it’s not used, duplicity fails loading the b2:// backend. > BackendException: B2 backend requires B2 Python SDK (pip install b2sdk)
Profpatsch
force-pushed
the
duplicity-fix-b2-backend
branch
from
0e1b86a
to
46ddaee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The backblaze library moved into the b2sdk package.
If it’s not used, duplicity fails loading the b2:// backend.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)