Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django-widget-tweaks: init at 1.4.8 #95737

Merged
merged 2 commits into from Aug 21, 2020
Merged

pythonPackages.django-widget-tweaks: init at 1.4.8 #95737

merged 2 commits into from Aug 21, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Aug 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maxxk maxxk changed the title Django widget tweaks pythonPackages.django-widget-tweaks: init at 1.4.8 Aug 18, 2020
@maxxk
Copy link
Contributor Author

maxxk commented Aug 18, 2020

nixpkgs-review fails with unrelated error, I think:

error: while evaluating 'callPackageWith' at /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/lib/customisation.nix:117:35, called from /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/pkgs/top-level/all-packages.nix:17893:18:
while evaluating 'makeOverridable' at /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/lib/customisation.nix:67:24, called from /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/lib/customisation.nix:121:8:
while evaluating anonymous function at /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/pkgs/development/tools/gocode-gomod/default.nix:1:1, called from /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/lib/customisation.nix:69:16:
anonymous function at /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/pkgs/development/go-modules/generic/default.nix:3:1 called without required argument 'vendorSha256', at /home/maxxk/.cache/nixpkgs-review/rev-04386a6a506d6cf4da597f82c794b7ee037bb4c9-dirty/nixpkgs/pkgs/development/tools/gocode-gomod/default.nix:3:1

FRidh
FRidh requested changes Aug 18, 2020
View reviewed changes
pkgs/development/python-modules/django-widget-tweaks/default.nix Outdated
sha256 = "00w1ja56dc7cyw7a3mph69ax6mkch1lsh4p98ijdhzfpjdy36rbg";
};

checkPhase = "python runtests.py";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${python.interpreter} instead of python because python does not always exist (e.g. in case of pypy)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you! Verified that tests work in pypy (pypy3Packages.django-widget-tweaks).

@zowoq
Copy link
Contributor

zowoq commented Aug 18, 2020

@ofborg eval

@maxxk maxxk requested a review from FRidh August 18, 2020 10:55
jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/95737
2 packages built:
python37Packages.django-widget-tweaks python38Packages.django-widget-tweaks

@jonringer jonringer merged commit c8384cc into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxxk @zowoq @FRidh @jonringer