Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cfn lint bump #95740

Closed
wants to merge 2 commits into from
Closed

Cfn lint bump #95740

wants to merge 2 commits into from

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Aug 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame
Copy link
Contributor Author

endgame commented Aug 18, 2020

I fail to see how this change could correspond to ofborg failures in unrelated go modules.

@zowoq
Copy link
Contributor

zowoq commented Aug 18, 2020

@ofborg eval

@siraben
Copy link
Member

siraben commented Aug 19, 2020

@GrahamcOfBorg build python3Packages.cfn-lint

@jonringer
Copy link
Contributor

these were added as part of #95609

@jonringer
Copy link
Contributor

they are in staging now

@jonringer jonringer closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endgame @zowoq @siraben @jonringer