Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-vanity-hash: init at 2020-02-26 #95717

Merged
merged 1 commit into from Oct 18, 2020
Merged

git-vanity-hash: init at 2020-02-26 #95717

merged 1 commit into from Oct 18, 2020

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Aug 17, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Content:

├── bin
│   └── git-vanity-hash
└── share
    └── doc
        └── git-vanity-hash
            └── README.md

4 directories, 2 files

Closure size:

/nix/store/70g14lxdfi420w8mxnqdrwqksnrfdkxi-git-vanity-hash-unstable-2020-02-26	   33510144

@maxxk
Copy link
Contributor

maxxk commented Aug 18, 2020

Works for me:

$ git-vanity-hash find cafe
Found hash: cafea47ad24a44f3a597bed4926a3bf3dba5e3a9

$ git-vanity-hash find beef
Found hash: beef53bfef9cf61c460f75f1441979879697f1aa

$ git-vanity-hash find feed
Found hash: feed66c97bfba4858e07a3acc8904220a0521f0e

raboof
raboof approved these changes Aug 30, 2020
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-vanity-hash/default.nix Outdated

meta = with stdenv.lib; {
homepage = "https://github.com/prasmussen/git-vanity-hash";
description = "tool for creating commit hashes with a specific prefix";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "tool for creating commit hashes with a specific prefix";
description = "Tool for creating commit hashes with a specific prefix";

pkgs/applications/version-management/git-and-tools/default.nix Show resolved Hide resolved
@KAction
Copy link
Contributor Author

KAction commented Aug 30, 2020

Applied.

@KAction
Copy link
Contributor Author

KAction commented Oct 7, 2020

Ping? What is missing for merging?

@KAction
Copy link
Contributor Author

KAction commented Oct 17, 2020

@ryantm Can you please merge this?

@ryantm
Copy link
Member

ryantm commented Oct 18, 2020

Result of nixpkgs-review pr 95717 1

1 package built:
- gitAndTools.git-vanity-hash

@ryantm ryantm merged commit 396f340 into NixOS:master Oct 18, 2020
@KAction KAction deleted the git-vanity-hash branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KAction @maxxk @ryantm @raboof