pythonPackages.rdflib-jsonld: init at 0.5.0 #95711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 17, 2020
| , rdflib | ||
| }: | ||
| buildPythonPackage rec { | ||
| name = "rdflib-jsonld"; |
There was a problem hiding this comment.
Suggested change
| name = "rdflib-jsonld"; | |
| pname = "rdflib-jsonld"; |
| url = "https://files.pythonhosted.org/packages/f5/17/45e137be0d93b70827fe5529c0400731344a978bc792193d7d9152e6dbe4/${name}-${version}.tar.gz"; | ||
| sha256 = "4f7d55326405071c7bce9acf5484643bcb984eadb84a6503053367da207105ed"; | ||
| }; | ||
| doCheck = true; |
There was a problem hiding this comment.
default
Suggested change
| doCheck = true; |
| sha256 = "4f7d55326405071c7bce9acf5484643bcb984eadb84a6503053367da207105ed"; | ||
| }; | ||
| doCheck = true; | ||
| format = "setuptools"; |
There was a problem hiding this comment.
default
Suggested change
| format = "setuptools"; |
Comment on lines
10
to
13
| src = fetchurl { | ||
| url = "https://files.pythonhosted.org/packages/f5/17/45e137be0d93b70827fe5529c0400731344a978bc792193d7d9152e6dbe4/${name}-${version}.tar.gz"; | ||
| sha256 = "4f7d55326405071c7bce9acf5484643bcb984eadb84a6503053367da207105ed"; | ||
| }; |
There was a problem hiding this comment.
use fetchPypi
Suggested change
| src = fetchurl { | |
| url = "https://files.pythonhosted.org/packages/f5/17/45e137be0d93b70827fe5529c0400731344a978bc792193d7d9152e6dbe4/${name}-${version}.tar.gz"; | |
| sha256 = "4f7d55326405071c7bce9acf5484643bcb984eadb84a6503053367da207105ed"; | |
| }; | |
| src = fetchPypi { | |
| inherit pname version; | |
| sha256 = ...; | |
| }; |
|
@koslambrou thanks for opening your first PR please look at https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/rope/default.nix for an example of a python package which uses nose |
|
i notcied you force pushed after closing the PR, did you mean to do that? |
|
@jonringer Oups not at all. Just finished creating the 2 commits with all the suggestions in my branch. |
jonringer
approved these changes
Aug 17, 2020
jonringer
approved these changes
Aug 17, 2020
|
@jonringer I finished applying the changes. Thanks for the review :) |
jonringer
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
added rdflib-jsonld python package
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)