Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python3Packages.*: additional python stabilization #95738

Merged
merged 8 commits into from Aug 19, 2020
Merged

[staging] python3Packages.*: additional python stabilization #95738

merged 8 commits into from Aug 19, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 18, 2020 •
edited

Motivation for this change

some additional stabilization

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner August 18, 2020 08:44
mweinelt
mweinelt reviewed Aug 18, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The home-assistant changes LGTM.

@jonringer jonringer changed the title Fix staging py [staging] python3Packages.*: additional python stabilization Aug 18, 2020
@jonringer
Copy link
Contributor Author

The home-assistant tests are failing because stage1 boot is failing on staging

@ofborg ofborg bot requested a review from mweinelt August 18, 2020 23:41
@jonringer
Copy link
Contributor Author

fixes some more failing builds

@jonringer jonringer merged commit bf88039 into NixOS:staging Aug 19, 2020
@jonringer jonringer deleted the fix-staging-py branch September 28, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

@Mic92 Mic92 Awaiting requested review from Mic92

@benley benley Awaiting requested review from benley

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

@marsam marsam Awaiting requested review from marsam

@marenz2569 marenz2569 Awaiting requested review from marenz2569

@mweinelt mweinelt Awaiting requested review from mweinelt mweinelt is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mweinelt