Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: ef5246f027d7
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 30842d0263f4
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 17, 2020

  1. lib/modules: Fix nonexistant option error 

    The refactoring in fd75dc8
introduced a mistake in the error message that doesn't show the full
context anymore. E.g. with this module:

  options.foo.bar = lib.mkOption {
    type = lib.types.submodule {
      baz = 10;
    };
    default = {};
  };

You'd get the error

  The option `baz' defined in `/home/infinisil/src/nixpkgs/config.nix' does not exist.

instead of the previous

  The option `foo.bar.baz' defined in `/home/infinisil/src/nixpkgs/config.nix' does not exist.

This commit undoes this regression
    @infinisil
    infinisil committed Aug 17, 2020
    Copy the full SHA
    d5700d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. Merge pull request #95718 from Infinisil/fixup-nonexistant-option-error 

    lib/modules: Fix nonexistant option error
    @Ma27
    Ma27 committed Aug 18, 2020
    Copy the full SHA
    30842d0 View commit details
    Browse the repository at this point in the history