Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closurecompiler: 20200614 -> 20200719 #94380

Merged
merged 1 commit into from Aug 29, 2020

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/closure-compiler/versions.

meta.description for closurecompiler is: "A tool for making JavaScript download and run faster"

meta.homepage for closurecompiler is: "https://developers.google.com/closure/compiler/"

meta.changelog for closurecompiler is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
57 total rebuild path(s)

19 package rebuild(s)

19 x86_64-linux rebuild(s)
17 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
17 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
closurecompiler
emscripten
faust
faust2
faust2alqt
faust2alsa
faust2csound
faust2firefox
faust2jack
faust2jackrust
faust2jaqt
faust2ladspa
faust2lv2
faustlive
foo-yc20
meguca
purePackages.faust
tambura
tree-sitter
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A closurecompiler https://github.com/r-ryantm/nixpkgs/archive/1f9ccd8264e266c62c96cb1895a516a89e6e6a6d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719
ls -la /nix/store/4b20zlbsgv74bghsalf5mhdh7mcz9d54-closure-compiler-20200719/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

21 packages failed to build:
  • emscripten
  • emscriptenPackages.json_c
  • emscriptenPackages.libxml2
  • emscriptenPackages.xmlmirror
  • emscriptenPackages.zlib
  • faust
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2firefox
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faustlive
  • foo-yc20
  • meguca
  • purePackages.faust
  • tambura
  • tree-sitter
1 package built:
  • closurecompiler

Maintainer pings

@magnetophon
Copy link
Member

As a maintainer of the faust packages, I feel I need to test this, but I don't even know what it is!
Could someone enlighten me?

Pinging the last 3 people that merged commits to this file:
@marsam @Mic92 @xeji

@Mic92
Copy link
Member

Mic92 commented Aug 4, 2020

@magnetophon It optimize javascript code by removing dead code and minifying it.

@magnetophon
Copy link
Member

Thanks!

@gebner gebner force-pushed the auto-update/closure-compiler branch from 1f9ccd8 to 0be4c80 Compare August 29, 2020 13:59
@gebner
Copy link
Member

gebner commented Aug 29, 2020

I believe all of the build errors were due to the emscripten build failure.

@gebner gebner merged commit f12bc6e into NixOS:master Aug 29, 2020
@r-ryantm r-ryantm deleted the auto-update/closure-compiler branch August 31, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants