Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.more-itertools: 8.3.0 -> 8.4.0 #94343

Closed
wants to merge 1 commit into from
Closed

python3Packages.more-itertools: 8.3.0 -> 8.4.0 #94343

wants to merge 1 commit into from

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jul 31, 2020 •
edited

Motivation for this change

New more-itertools version. https://github.com/more-itertools/more-itertools/blob/fc70d910cd2a8579e9b4e5fd38f8a8acf4abb2d7/docs/versions.rst#840

No deprecations, implementation improvements, new itertools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger changed the base branch from master to staging July 31, 2020 14:36
@jonringer
Copy link
Contributor

This should probably be added to #94310

@FRidh
Copy link
Member

FRidh commented Aug 15, 2020

@GrahamcOfBorg build python3.pkgs.more-itertools

@drewrisinger
Copy link
Contributor Author

Closed by 6db31f7

@drewrisinger drewrisinger deleted the dr-pr-more-itertools branch September 10, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @jonringer @FRidh