Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CPANMini: init at 1.111016 #94388

Merged
merged 1 commit into from Aug 1, 2020
Merged

perlPackages.CPANMini: init at 1.111016 #94388

merged 1 commit into from Aug 1, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jul 31, 2020

Adds the CPAN::Mini Perl module and minicpan executable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from volth and aanderse July 31, 2020 23:25
@stigtsp
Copy link
Member Author

stigtsp commented Jul 31, 2020

@GrahamcOfBorg build perlPackages.CPANMini perldevelPackages.CPANMini

@stigtsp stigtsp force-pushed the package/perl-cpan-mini-init branch from 6fdbe4a to 9ffc60d Compare July 31, 2020 23:34
@stigtsp
Copy link
Member Author

stigtsp commented Aug 1, 2020

@GrahamcOfBorg build perl528Packages.CPANMini perl530Packages.CPANMini perldevelPackages.CPANMini

@aanderse
Copy link
Member

aanderse commented Aug 1, 2020

@GrahamcOfBorg build perlPackages.CPANMini perldevelPackages.CPANMini

@aanderse
Copy link
Member

aanderse commented Aug 1, 2020

@stigtsp looks like bot still won't build darwin for you... 😦

@aanderse aanderse merged commit bb96f89 into NixOS:master Aug 1, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Aug 1, 2020

@stigtsp looks like bot still won't build darwin for you... frowning

Yeah 😢 @grahamc help pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse