You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are currently at least three different ways venvs are set up:
tools/wpt/tox.ini creates a venv itself that contains the dependencies to run some tests. This kind of defeats the purpose of integration tests as we are not managing the venv in the same way as the wpt command and could hide issues like [DO NOT SUBMIT] Reproduce MacOS + Py3.8 mozinstall failure #24813 .
test_install.py etc. invokes wpt.main which uses the top-level _venv*. This is problematic as we either leak states across tests or purge the top-level venv (slowing down real commands).
test_run.py etc. creates a fresh venv in a temporary directory and passes it to the command functions. This is largely a dummy venv with no-op install methods to test setup_wptrunner.
Maybe we should use a hybrid of 2 and 3: creating a temporary venv and passing it to wpt.main. tox.ini should then only contain dependencies needed by the unit tests themselves, not the wpt commands.
The text was updated successfully, but these errors were encountered:
This is from #24813 (comment)
There are currently at least three different ways venvs are set up:
tools/wpt/tox.ini
creates a venv itself that contains the dependencies to run some tests. This kind of defeats the purpose of integration tests as we are not managing the venv in the same way as thewpt
command and could hide issues like [DO NOT SUBMIT] Reproduce MacOS + Py3.8 mozinstall failure #24813 .test_install.py
etc. invokeswpt.main
which uses the top-level_venv*
. This is problematic as we either leak states across tests or purge the top-level venv (slowing down real commands).test_run.py
etc. creates a fresh venv in a temporary directory and passes it to the command functions. This is largely a dummy venv with no-op install methods to testsetup_wptrunner
.Maybe we should use a hybrid of 2 and 3: creating a temporary venv and passing it to
wpt.main
.tox.ini
should then only contain dependencies needed by the unit tests themselves, not the wpt commands.The text was updated successfully, but these errors were encountered: