That is convenient but not necessary to install chruby-fish. So I attempted to keep dependencies minimum. For example, when someone is using both chruby and chruby-fish for bash and fish respectively, this may avoid trouble.

That is convenient but not necessary to install chruby-fish. So I attempted to keep dependencies minimum. For example, when someone is using both chruby and chruby-fish for bash and fish respectively, this may avoid trouble.

ehm, I meant that you can add chruby to chruby-fish path. there will be no chruby in shell path.

Like 6039f5e ?

Like 6039f5e ?

Nope. Like this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/emulators/mednaffe/default.nix#L21

Add makeWrapper to your buildInputs, and run wrapProgram $out/bin/chruby-fish --set PATH ${chruby}/bin in postInstall phase.

Thank you for the example! I'll try.

Add makeWrapper to your buildInputs, and run wrapProgram $out/bin/chruby-fish --set PATH ${chruby}/bin in postInstall phase.

chruby-fish's main resources are share/chruby/{chruby,auto}.fish. There is no executable, so it is impossible to do wrapPropram like this.

Is there anything else I can do?

Sorry for everything you've already been through to merge the stuff

E.g can do sed -i 's\chruby${chruby}/bin/chruby'.

Initially I thought that's an utility which uses chruby as a dependency, but turns out that's more of a shell extension. So probably you don't even need to do that. I will pull PR in a sec and poke around a bit.

Result of nixpkgs-review pr 94345 1

I read a bit more. Turns out, chruby is a script itself, and doesn't pull whole ruby with itself)

Although it's totally fine as a package, it still requires CHRUBY_ROOT environment variable. It would be nice to set it inside auto.fish and chruby.fish on patchPhase.

diff --git a/pkgs/development/tools/misc/chruby-fish/default.nix b/pkgs/development/tools/misc/chruby-fish/default.nix
index b8acc475204..8e552b4a9a5 100644
--- a/pkgs/development/tools/misc/chruby-fish/default.nix
+++ b/pkgs/development/tools/misc/chruby-fish/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, lib, fetchFromGitHub }:
+{ stdenv, lib, fetchFromGitHub, chruby }:

 stdenv.mkDerivation rec {
   pname = "chruby-fish";
@@ -12,6 +12,11 @@ stdenv.mkDerivation rec {
     sha256 = "15q0ywsn9pcypbpvlq0wb41x4igxm9bsvhg9a05dqw1n437qjhyb";
   };

+  postInstall = ''
+    sed -i -e '1cset CHRUBY_ROOT ${chruby}' $out/share/chruby/auto.fish
+    sed -i -e '1cset CHRUBY_ROOT ${chruby}' $out/share/chruby/chruby.fish
+  '';
+
   installFlags = [ "PREFIX=$(out)" ];

   meta = {

I can't edit your PR, so here's a patch)

@cohei ?

Never mind! Thanks to the detour, I understand Nix more than before.

Also, you can post this PR here, and there will be contributors with merge flag

They say

Select an open pull request that is not your own

Could you post it there instead, if you don't mind?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/241