Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneDNN: 1.5.1 -> 1.6 #94420

Merged
merged 1 commit into from Aug 7, 2020
Merged

oneDNN: 1.5.1 -> 1.6 #94420

merged 1 commit into from Aug 7, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 1, 2020

Motivation for this change

Changelog:

https://github.com/oneapi-src/oneDNN/releases/tag/v1.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title oneDNN: 1.5.1 -> 1.6.0 oneDNN: 1.5.1 -> 1.6 Aug 1, 2020
@ofborg ofborg bot requested review from alexarice and bhipple August 1, 2020 07:50
@danieldk
Copy link
Contributor Author

danieldk commented Aug 7, 2020

Result of nixpkgs-review pr 94420 1

2 package marked as broken and skipped:
  • python37Packages.pyro-ppl
  • python38Packages.pyro-ppl
2 package failed to build:
  • python37Packages.tensorboardx
  • python38Packages.tensorboardx
19 package built:
  • oneDNN
  • python37Packages.ignite
  • python37Packages.pytorch (python37Packages.pytorchWithoutCuda)
  • python37Packages.pytorch-metric-learning
  • python37Packages.pytorchWithCuda
  • python37Packages.pywick
  • python37Packages.skorch
  • python37Packages.tensorly
  • python37Packages.torchgpipe
  • python37Packages.torchvision
  • python38Packages.ignite
  • python38Packages.pytorch (python38Packages.pytorchWithoutCuda)
  • python38Packages.pytorch-metric-learning
  • python38Packages.pytorchWithCuda
  • python38Packages.pywick
  • python38Packages.skorch
  • python38Packages.tensorly
  • python38Packages.torchgpipe
  • python38Packages.torchvision

@danieldk danieldk merged commit 9531f98 into NixOS:master Aug 7, 2020
@danieldk danieldk deleted the onednn-1.6 branch August 7, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice Awaiting requested review from alexarice

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danieldk