Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up venv configs in commands.json #24830

Merged
merged 2 commits into from Aug 5, 2020
Merged

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Jul 31, 2020

  1. Fold most dependencies in "install" into existing requirements.txt
  2. Fail when a command has either "install" or "requirements" but
    disables "virtualenv".

1. Fold dependencies in "install" into existing requirements.txt
2. Warn when a command has both "install" and "requirements"
3. Fail when a command has either "install" or "requirements" but
   disables "virtualenv".
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-24830 July 31, 2020 17:25 Inactive
@Hexcles
Copy link
Member Author

Hexcles commented Aug 4, 2020

Unit test failures seem unrelated: filed #24880

@Hexcles Hexcles marked this pull request as ready for review August 4, 2020 20:25
@wpt-pr-bot wpt-pr-bot added infra serve wpt wptrunner The automated test runner, commonly called through ./wpt run labels Aug 4, 2020
tools/wptrunner/requirements.txt Outdated Show resolved Hide resolved
@Hexcles Hexcles merged commit fd2922b into master Aug 5, 2020
@Hexcles Hexcles deleted the clean-up-commands-venv branch August 5, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra serve wpt wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants