Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 4.4.3 -> 4.7.0 (linux), 4.6.0 -> 4.8.0 (darwin) #94337

Merged
merged 1 commit into from Jul 31, 2020
Merged

slack: 4.4.3 -> 4.7.0 (linux), 4.6.0 -> 4.8.0 (darwin) #94337

merged 1 commit into from Jul 31, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jul 31, 2020

Motivation for this change
  1. Update to 4.8.0 on darwin (Slack for Mac - Release Notes)
  2. Update to 4.7.0 on linux (Slack for Linux - Release Notes)
  3. Fix macos download link
  4. Use undmg hook instead of /usr/bin/hdiutil (undmg>=1.0.5 properly handles symlinks now, undmg: 1.0.3 -> 1.0.5 #94106)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 31, 2020
srhb
srhb requested changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Linux, it looks like we need more deps, libdrm and mesa it seems:

/nix/store/c8m5gvpb4b65pc3rfp9r9mzqxx5ws2jq-slack-4.7.0/lib/slack/slack: error while loading shared libraries: libdrm.so.2: cannot open shared object file: No such file or directory

@sikmir
Copy link
Member Author

sikmir commented Jul 31, 2020

On Linux, it looks like we need more deps, libdrm and mesa it seems:

/nix/store/c8m5gvpb4b65pc3rfp9r9mzqxx5ws2jq-slack-4.7.0/lib/slack/slack: error while loading shared libraries: libdrm.so.2: cannot open shared object file: No such file or directory

Added, try it now.

@srhb
Copy link
Contributor

srhb commented Jul 31, 2020

No go, I think they need to be jammed into the rpath :)

@sikmir
Copy link
Member Author

sikmir commented Jul 31, 2020

No go, I think they need to be jammed into the rpath :)

Fixed, I hope. I just away from my nixos machine right now, so can't check it.

@srhb
Copy link
Contributor

srhb commented Jul 31, 2020

Confirmed, this works on NixOS. I assume you've tested on OS X? :)

@sikmir
Copy link
Member Author

sikmir commented Jul 31, 2020

I assume you've tested on OS X? :)

Sure.

@srhb srhb merged commit ba21e8b into NixOS:master Jul 31, 2020
@sikmir sikmir deleted the slack branch July 31, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@ersinakinci ersinakinci Awaiting requested review from ersinakinci

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @srhb @NeQuissimus