Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 3.0.0 -> 3.0.1 and rename it to openethereum #94413

Merged
merged 1 commit into from Aug 14, 2020
Merged

parity: 3.0.0 -> 3.0.1 and rename it to openethereum #94413

merged 1 commit into from Aug 14, 2020

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Aug 1, 2020

Motivation for this change

They've renamed the project to OpenEthereum, and released a new minor version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@enolan enolan requested a review from mmahut as a code owner August 1, 2020 06:05
@ofborg ofborg bot requested a review from akru August 1, 2020 06:19
rnhmjoj
rnhmjoj requested changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid users getting errors when updating Nixpkgs, you should always add an alias with the old name.
Add a definition in pkgs/top-level/aliases.nix with a date in a comment, please.

@enolan
Copy link
Contributor Author

enolan commented Aug 1, 2020

done :)

rnhmjoj
rnhmjoj approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
It looks good to me, now but I'll wait for @mmahut before merging.

akru
akru approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@akru akru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@enolan
Copy link
Contributor Author

enolan commented Aug 12, 2020

@mmahut ping?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Aug 14, 2020

I think this has waited enough, let's merge it.

@rnhmjoj rnhmjoj merged commit 1db6681 into NixOS:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru akru approved these changes

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enolan @rnhmjoj @akru