Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlightenment.efl: do not default to openjpeg 1 #94341

Merged
merged 1 commit into from Aug 1, 2020
Merged

enlightenment.efl: do not default to openjpeg 1 #94341

merged 1 commit into from Aug 1, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jul 31, 2020

Motivation for this change

There is no apparent reason to use version 1 of openjpeg. Just use the default openjpeg, which currerntly is openjpeg-2.3.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It seems there is no reason to choose openjpeg-1. Just use the default
openjpeg, which currerntly is openjpeg-2.3.1.
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openjpeg1 looks like something left over from an old bug that was fixed years ago:
https://phab.enlightenment.org/T3064

@xeji xeji merged commit 1e55e22 into NixOS:master Aug 1, 2020
@romildo romildo deleted the fix.efl branch August 1, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants