Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 33ad81eadd15
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 45fec46f4dd2
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 31, 2020

  1. applet.program.avr.spi: fix address masks for EEPROM write. 

    The masking is handled on an upper level anyway, since the lower
interface doesn't know anything about the device.

Before this commit, only 64 EEPROM bytes out of every 256 would be
actually written. (It would then fail verification.)
    @whitequark
    whitequark committed Jul 31, 2020
    Copy the full SHA
    45fec46 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 software/glasgow/applet/program/avr/spi.py
4 changes: 2 additions & 2 deletions software/glasgow/applet/program/avr/spi.py
View file
Original file line number Diff line number Diff line change
@@ -134,7 +134,7 @@ async def read_eeprom(self, address):
self._log("read EEPROM address %#06x", address)
_, _, _, data = await self._command(
0b1010_0000,
(address >> 8) & 0x1f,
(address >> 8) & 0xff,
(address >> 0) & 0xff,
0)
return data
@@ -152,7 +152,7 @@ async def write_eeprom_page(self, address):
await self._command(
0b1100_0010,
(address >> 8) & 0xff,
(address >> 0) & 0x3f,
(address >> 0) & 0xff,
0)
while await self._is_busy(): pass