Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bac4f8ae1850
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: da686139d75e
Choose a head ref
  • 18 commits
  • 16 files changed
  • 13 contributors

Commits on Jul 30, 2020

  1. Copy the full SHA
    46ea069 View commit details
  2. dockerTools: fix permissions on /nix/store

    Johan Thomsen committed Jul 30, 2020
    Copy the full SHA
    9f86685 View commit details

Commits on Jul 31, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    aa0fa84 View commit details
  2. pueue: 0.6.1 -> 0.7.1

    r-ryantm committed Jul 31, 2020
    Copy the full SHA
    1673bc9 View commit details
  3. python27Packages.chart-studio: 1.0.0 -> 1.1.0

    r-ryantm authored and Jon committed Jul 31, 2020
    Copy the full SHA
    fb4535c View commit details
  4. muse: 3.1.0 -> 3.1.1

    r-ryantm authored and Jon committed Jul 31, 2020
    Copy the full SHA
    7be4615 View commit details
  5. python27Packages.colorlog: 4.1.0 -> 4.2.1

    r-ryantm authored and Jon committed Jul 31, 2020
    Copy the full SHA
    2920f93 View commit details
  6. lmms: 1.2.1 -> 1.2.2

    mikefaille authored and Jon committed Jul 31, 2020
    Copy the full SHA
    fa06748 View commit details
  7. Merge pull request #94289 from NixOS/dependabot/github_actions/techno…

    …te-space/get-diff-action-v2.0.2
    dependabot[bot] authored Jul 31, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    497705f View commit details
  8. discord-canary: 0.0.104 -> 0.0.105

    ryantm authored and Jon committed Jul 31, 2020
    Copy the full SHA
    9f67493 View commit details
  9. nano: 4.9.3 -> 5.0

    lsix authored and Jon committed Jul 31, 2020
    Copy the full SHA
    7bec3a3 View commit details
  10. Merge pull request #94215 from mikefaille/dhall-lsp-server

    dhall-lsp-server: init at 1.0.8 on all packages
    cdepillabout authored Jul 31, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    471f367 View commit details
  11. nixos/tests/dockerTools: add test for running non-root containers wit…

    …h buildLayeredImage
    
    Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
    Johan Thomsen and roberth committed Jul 31, 2020
    Copy the full SHA
    f5db415 View commit details
  12. Merge pull request #94243 from johanot/dockertools-fix-nixstore-perms

    dockertools: fix buildLayeredImage nix-store permissions
    srhb authored Jul 31, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c5a1eaf View commit details
  13. python2Packages.statsmodels: disable py27, abandoned

    ```
      Processing ./statsmodels-0.11.1-cp27-cp27mu-linux_x86_64.whl
      ERROR: Package 'statsmodels' requires a different Python: 2.7.18 not in '>=3.5'
    ```
    Jonathan Ringer authored and FRidh committed Jul 31, 2020
    Copy the full SHA
    a6be138 View commit details
  14. gnomeExtensions.gsconnect: 38 -> 39

    doronbehar authored and bjornfor committed Jul 31, 2020
    Copy the full SHA
    b0edcfd View commit details
  15. mimetic: patch for aarch64

    ehmry committed Jul 31, 2020
    Copy the full SHA
    f153d9f View commit details
  16. Merge pull request #94299 from r-ryantm/auto-update/pueue

    pueue: 0.6.1 -> 0.7.1
    marsam authored Jul 31, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    da68613 View commit details
2 changes: 1 addition & 1 deletion .github/workflows/editorconfig.yml
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: technote-space/get-diff-action@v1.2.8
- uses: technote-space/get-diff-action@v2.0.2
- name: editorconfig check
env:
VERSION: "2.0.4"
10 changes: 10 additions & 0 deletions nixos/tests/docker-tools.nix
Original file line number Diff line number Diff line change
@@ -79,6 +79,16 @@ import ./make-test-python.nix ({ pkgs, ... }: {
"docker rmi ${examples.nix.imageName}",
)
with subtest(
"Ensure (layered) nix store has correct permissions "
"and that the container starts when its process does not have uid 0"
):
docker.succeed(
"docker load --input='${examples.bashLayeredWithUser}'",
"docker run -u somebody --rm ${examples.bashLayeredWithUser.imageName} ${pkgs.bash}/bin/bash -c 'test 555 == $(stat --format=%a /nix) && test 555 == $(stat --format=%a /nix/store)'",
"docker rmi ${examples.bashLayeredWithUser.imageName}",
)
with subtest("The nix binary symlinks are intact"):
docker.succeed(
"docker load --input='${examples.nix}'",
4 changes: 2 additions & 2 deletions pkgs/applications/audio/lmms/default.nix
Original file line number Diff line number Diff line change
@@ -5,13 +5,13 @@

mkDerivation rec {
pname = "lmms";
version = "1.2.1";
version = "1.2.2";

src = fetchFromGitHub {
owner = "LMMS";
repo = "lmms";
rev = "v${version}";
sha256 = "08k2nfj0rw9mahr7pr90n79wviqmjmflrgcljc6y3x30v84wbp26";
sha256 = "006hwv1pbh3y5whsxkjk20hsbgwkzr4dawz43afq1gil69y7xpda";
fetchSubmodules = true;
};

4 changes: 2 additions & 2 deletions pkgs/applications/audio/muse/default.nix
Original file line number Diff line number Diff line change
@@ -5,13 +5,13 @@

stdenv.mkDerivation rec {
pname = "muse-sequencer";
version = "3.1.0";
version = "3.1.1";

src = fetchFromGitHub {
owner = "muse-sequencer";
repo = "muse";
rev = "muse_${builtins.replaceStrings ["."] ["_"] version}";
sha256 = "08k25652w88xf2i79lw305x1phpk7idrww9jkqwcs8q6wzgmz8aq";
sha256 = "1rasp2v1ds2aw296lbf27rzw0l9fjl0cvbvw85d5ycvh6wkm301p";
};

sourceRoot = "source/muse3";
4 changes: 2 additions & 2 deletions pkgs/applications/editors/nano/default.nix
Original file line number Diff line number Diff line change
@@ -20,11 +20,11 @@ let

in stdenv.mkDerivation rec {
pname = "nano";
version = "4.9.3";
version = "5.0";

src = fetchurl {
url = "mirror://gnu/nano/${pname}-${version}.tar.xz";
sha256 = "1d2i3wvsq5lvpxxinq51dcvd58xx7j0d0c2csz9hgvd06gq3hd3f";
sha256 = "0dmagj4p1llb1a2w0iwdrqbd9cgp0bda4s18vwh6y1ndd6z983bw";
};

nativeBuildInputs = [ texinfo ] ++ optional enableNls gettext;
6 changes: 3 additions & 3 deletions pkgs/applications/misc/pueue/default.nix
Original file line number Diff line number Diff line change
@@ -2,16 +2,16 @@

rustPlatform.buildRustPackage rec {
pname = "pueue";
version = "0.6.1";
version = "0.7.1";

src = fetchFromGitHub {
owner = "Nukesor";
repo = pname;
rev = "v${version}";
sha256 = "0x8slqxpnk4pis834g11wzp8fqsxwhdf0xnssz1pkkww4dqzali0";
sha256 = "1ksks8c35q9aq5vnjxh480vqjyaa8c1fz1fb465vngnlyw762b22";
};

cargoSha256 = "0r110zlzpzg0j5cq9zg0kk46qigp6bzd0kzmpx3ddvhblhxvq5m5";
cargoSha256 = "0v1h4jhrzfb55zmpnbq18188rdvx7a7lvnjqh0w7cy90kvxssian";

nativeBuildInputs = [ installShellFiles ];

Original file line number Diff line number Diff line change
@@ -17,20 +17,20 @@ in {
pname = "discord-ptb";
binaryName = "DiscordPTB";
desktopName = "Discord PTB";
version = "0.0.19";
version = "0.0.20";
src = fetchurl {
url = "https://dl-ptb.discordapp.net/apps/linux/${version}/discord-ptb-${version}.tar.gz";
sha256 = "0wixmm16qsmgbr0l9144vl5pc3s2p4jqhl7cnc6kmgy1y4ig56ib";
sha256 = "0wn2qdv0a4n59xl451y7fcq11klp2g63qwx40qkshllvnf5lzzsx";
};
};
canary = callPackage ./base.nix rec {
pname = "discord-canary";
binaryName = "DiscordCanary";
desktopName = "Discord Canary";
version = "0.0.104";
version = "0.0.105";
src = fetchurl {
url = "https://dl-canary.discordapp.net/apps/linux/${version}/discord-canary-${version}.tar.gz";
sha256 = "17np1hqqygjlbmlln0d1ba2qlbjykwj156w5dw7g4lg77kfxicfk";
sha256 = "1jc2zr8q33ras5mkifg19kcxpb84vsqx01rj66w62hsjw1nsbidg";
};
};
}.${branch}
36 changes: 36 additions & 0 deletions pkgs/build-support/docker/examples.nix
Original file line number Diff line number Diff line change
@@ -382,4 +382,40 @@ rec {
contents = pkgs.bashInteractive;
};

# buildLayeredImage with non-root user
bashLayeredWithUser =
let
nonRootShadowSetup = { user, uid, gid ? uid }: with pkgs; [
(
writeTextDir "etc/shadow" ''
root:!x:::::::
${user}:!:::::::
''
)
(
writeTextDir "etc/passwd" ''
root:x:0:0::/root:${runtimeShell}
${user}:x:${toString uid}:${toString gid}::/home/${user}:
''
)
(
writeTextDir "etc/group" ''
root:x:0:
${user}:x:${toString gid}:
''
)
(
writeTextDir "etc/gshadow" ''
root:x::
${user}:x::
''
)
];
in
pkgs.dockerTools.buildLayeredImage {
name = "bash-layered-with-user";
tag = "latest";
contents = [ pkgs.bash pkgs.coreutils (nonRootShadowSetup { uid = 999; user = "somebody"; }) ];
};

}
8 changes: 6 additions & 2 deletions pkgs/build-support/docker/stream_layered_image.py
Original file line number Diff line number Diff line change
@@ -74,6 +74,10 @@ def apply_filters(ti):
ti.gname = "root"
return filter(ti)

def nix_root(ti):
ti.mode = 0o0555 # r-xr-xr-x
return ti

def dir(path):
ti = tarfile.TarInfo(path)
ti.type = tarfile.DIRTYPE
@@ -84,8 +88,8 @@ def dir(path):
# these directories first when building layer tarballs. But
# we don't need them on the customisation layer.
if add_nix:
tar.addfile(apply_filters(dir("/nix")))
tar.addfile(apply_filters(dir("/nix/store")))
tar.addfile(apply_filters(nix_root(dir("/nix"))))
tar.addfile(apply_filters(nix_root(dir("/nix/store"))))

for path in paths:
path = pathlib.Path(path)
4 changes: 2 additions & 2 deletions pkgs/desktops/gnome-3/extensions/gsconnect/default.nix
Original file line number Diff line number Diff line change
@@ -4,13 +4,13 @@

stdenv.mkDerivation rec {
pname = "gnome-shell-gsconnect";
version = "38";
version = "39";

src = fetchFromGitHub {
owner = "andyholmes";
repo = "gnome-shell-extension-gsconnect";
rev = "v${version}";
sha256 = "1z5wn3n1sqc2xdxiq0g3dkga7srz5ak41qdyjsh9pzb5x93dxzi5";
sha256 = "0d2wypf36p95v756arf06gfilpb48gp55i1xbqnqvcd10n3q4zc2";
};

patches = [
2 changes: 2 additions & 0 deletions pkgs/development/libraries/mimetic/default.nix
Original file line number Diff line number Diff line change
@@ -11,6 +11,8 @@ stdenv.mkDerivation rec {

buildInputs = [ cutee ];

patches = stdenv.lib.optional stdenv.isAarch64 ./narrowing.patch;

meta = with stdenv.lib; {
description = "MIME handling library";
homepage = "http://www.codesink.org/mimetic_mime_library.html";
32 changes: 32 additions & 0 deletions pkgs/development/libraries/mimetic/narrowing.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
diff -ru a/mimetic/codec/base64.cxx b/mimetic/codec/base64.cxx
--- a/mimetic/codec/base64.cxx 2014-06-17 10:12:00.000000000 +0200
+++ b/mimetic/codec/base64.cxx 2020-07-30 20:54:10.212742011 +0200
@@ -14,19 +14,19 @@
"0123456789+/=";

const char Base64::sDecTable[] = {
- -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,
- -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,
- -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,
- -1,-1,-1,-1,-1,-1,-1,-1,-1,-1,
- -1,-1,-1,62,-1,-1,-1,63,52,53,
- 54,55,56,57,58,59,60,61,-1,-1,
- -1, eq_sign, -1,-1,-1, 0, 1, 2, 3, 4,
+ 255,255,255,255,255,255,255,255,255,255,
+ 255,255,255,255,255,255,255,255,255,255,
+ 255,255,255,255,255,255,255,255,255,255,
+ 255,255,255,255,255,255,255,255,255,255,
+ 255,255,255,62,255,255,255,63,52,53,
+ 54,55,56,57,58,59,60,61,255,255,
+ 255, eq_sign, 255,255,255, 0, 1, 2, 3, 4,
5, 6, 7, 8, 9,10,11,12,13,14,
15,16,17,18,19,20,21,22,23,24,
- 25,-1,-1,-1,-1,-1,-1,26,27,28,
+ 25,255,255,255,255,255,255,26,27,28,
29,30,31,32,33,34,35,36,37,38,
39,40,41,42,43,44,45,46,47,48,
- 49,50,51,-1
+ 49,50,51,255
};

const int Base64::sDecTableSz = sizeof(Base64::sDecTable) / sizeof(char);
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/chart-studio/default.nix
Original file line number Diff line number Diff line change
@@ -10,14 +10,14 @@

buildPythonPackage rec {
pname = "chart-studio";
version = "1.0.0";
version = "1.1.0";

# chart-studio was split from plotly
src = fetchFromGitHub {
owner = "plotly";
repo = "plotly.py";
rev = "${pname}-v${version}";
sha256 = "14lyqbjdffnlnkzlfnn60k7yxjd99vx3hfcs23apsiyinzipjlbf";
sha256 = "1q3j3ih5k0jhr8ilwffkfxp1nifpnjnx7862bzhxfg4d386hfg4i";
};

sourceRoot = "source/packages/python/chart-studio";
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/colorlog/default.nix
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@

buildPythonPackage rec {
pname = "colorlog";
version = "4.1.0";
version = "4.2.1";

src = fetchPypi {
inherit pname version;
sha256 = "1lpk8zmfv8vz090h5d0hzb4n39wgasxdd3x3bpn3v1x1n9dfzaih";
sha256 = "066i7904vc7814gqnlprksf0ikz2dmviw93r2mr7sf53qci5irbm";
};

checkInputs = [ pytest ];
1 change: 1 addition & 0 deletions pkgs/development/python-modules/statsmodels/default.nix
Original file line number Diff line number Diff line change
@@ -14,6 +14,7 @@
buildPythonPackage rec {
pname = "statsmodels";
version = "0.11.1";
disabled = isPy27;

src = fetchPypi {
inherit pname version;
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
@@ -9640,6 +9640,8 @@ in

dhall-json = haskell.lib.justStaticExecutables haskellPackages.dhall-json;

dhall-lsp-server = haskell.lib.justStaticExecutables haskellPackages.dhall-lsp-server;

dhall-text = haskell.lib.justStaticExecutables haskellPackages.dhall-text;

dhallPackages = callPackages ./dhall-packages.nix { };